Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to retrieve password from the environment or elsewhere #34355

Closed
nicacioliveira opened this issue Jul 31, 2024 · 3 comments
Closed
Labels
exporter/clickhouse question Further information is requested

Comments

@nicacioliveira
Copy link

Component(s)

exporter/clickhouse

Is your feature request related to a problem? Please describe.

For security reasons, it is bad when we have to pass the password directly to the collector configuration. I would like to have a way to get the password from the environment or from another location so as not to expose the password within the exporter configuration.

Describe the solution you'd like

Considering a Kubernetes environment, we can use the crd secret type to save the password.
Here, at my company we use the ExternalSecrets module configured with AWS secrets Manager because we rotate keys and because we would not like to expose credentials within a github repository.

Therefore, a simple way to recover the password from the env solves the problem.

Describe alternatives you've considered

No response

Additional context

No response

@nicacioliveira nicacioliveira added enhancement New feature or request needs triage New item requiring triage labels Jul 31, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@Frapschen
Copy link
Contributor

Hi,@nicacioliveira otel config file already support use env, please see https://opentelemetry.io/docs/collector/configuration/#environment-variables

@Frapschen Frapschen added question Further information is requested and removed needs triage New item requiring triage enhancement New feature or request labels Aug 1, 2024
@nicacioliveira
Copy link
Author

Thanks @Frapschen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/clickhouse question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants