Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric for image filesystem usage #34264

Open
epochstamp opened this issue Jul 26, 2024 · 6 comments
Open

Add a metric for image filesystem usage #34264

epochstamp opened this issue Jul 26, 2024 · 6 comments
Labels
enhancement New feature or request receiver/hostmetrics receiver/kubeletstats waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized

Comments

@epochstamp
Copy link

Component(s)

receiver/hostmetrics, receiver/kubeletstats

Is your feature request related to a problem? Please describe.

I am currently migrating a monitoring solution from metricbeats to OTLP and I would like to monitor the image filesystem usage like it is done in metricbeats through the metrics kubernetes.node.runtime.imagefs.capacity.bytes, kubernetes.node.runtime.imagefs.available.bytes and kubernetes.node.runtime.imagefs.used.bytes.

Describe the solution you'd like

Implement in the same fashion the metrics (in the kubeletstatsreceiver) k8s.node.imagefs.capacity, k8s.node.imagefs.available and k8s.node.imagefs.used, respectively.
Implementing the same kind of metrics in hostmetrics (filesystem scraper) with the naming pattern system.imagefs.{*} should also be considered imho.

Describe alternatives you've considered

No response

Additional context

No response

@epochstamp epochstamp added enhancement New feature or request needs triage New item requiring triage labels Jul 26, 2024
@epochstamp epochstamp changed the title Add a metric for image filsystem usage Add a metric for image filesystem usage Jul 26, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@braydonk
Copy link
Contributor

Would you mind opening this same request in https://github.com/open-telemetry/semantic-conventions?

I'll repeat this thought there, but my initial thought is that imagefs metrics may belong in an exclusive imagefs namespace, and once that is in semantic conventions both receivers could simply produce the same set of metrics (or whichever makes the most sense; sorry I'm just learning from this issue what imagefs is 😄)

@epochstamp
Copy link
Author

Sure, I'll take care of it !

Regarding the documentation of metricbeats, I would indeed agree that a new namespace is needed for that metric (though adding more inertia to this feature implementation :'()

(Don't worry, I'm also learning the whole stuff in my current position ^^)

@braydonk
Copy link
Contributor

though adding more inertia to this feature implementation

Yeah apologies for that; we're going through a big transition to make all new instrumentation go through semantic conventions and right now it's a big lift of everything that's here into proper semantic conventions. Stuff will get easier once we're through the growing pains of that transition. Thanks for your understanding!

@ChrsMark
Copy link
Member

Would you mind opening this same request in https://github.com/open-telemetry/semantic-conventions?

I'll repeat this thought there, but my initial thought is that imagefs metrics may belong in an exclusive imagefs namespace, and once that is in semantic conventions both receivers could simply produce the same set of metrics (or whichever makes the most sense; sorry I'm just learning from this issue what imagefs is 😄)

While that approach makes sense, one thing to verify here would be to ensure that kubeletstats and hostmetrics receivers can actually provide equivalent metrics. If that's true then enabling the metric in either of them should provide the same results.

kubeletstats receiver scrapes the Kubelet's stats endpoint hence we need to check if the provided value is aligned with what the hostmetrics receiver would collect.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 30, 2024
@atoulme atoulme removed the needs triage New item requiring triage label Oct 12, 2024
@github-actions github-actions bot removed the Stale label Oct 13, 2024
@mx-psi mx-psi added the waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/hostmetrics receiver/kubeletstats waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized
Projects
None yet
Development

No branches or pull requests

5 participants