Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Matching in httpcheck receiver #34069

Closed
agardnerIT opened this issue Jul 14, 2024 · 4 comments
Closed

Content Matching in httpcheck receiver #34069

agardnerIT opened this issue Jul 14, 2024 · 4 comments
Labels
closed as inactive enhancement New feature or request receiver/httpcheck HTTP Check receiver Stale

Comments

@agardnerIT
Copy link
Contributor

Component(s)

receiver/httpcheck

Is your feature request related to a problem? Please describe.

I need to retrieve endpoints and ensure that content is available in the DOM. Just because an endpoint returns a 200 OK doesn't mean it's healthy. A common pattern these days is to 200 OK return an "Sorry, we ran into an error" page.

Describe the solution you'd like

A user should be able to specify a "content match" rule for each endpoint. eg. "This domain is for use in illustrative examples in documents" in http.response_content for http://example.com

Describe alternatives you've considered

N/A

Additional context

No response

@agardnerIT agardnerIT added enhancement New feature or request needs triage New item requiring triage labels Jul 14, 2024
@github-actions github-actions bot added the receiver/httpcheck HTTP Check receiver label Jul 14, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten codeboten removed the needs triage New item requiring triage label Jul 15, 2024
@codeboten
Copy link
Contributor

Thanks for opening the issue @agardnerIT! An option to address a similar feature was proposed in #27015, adding it here for context.

Going from memory, the discussion in the SIG call was that it would be better to add an attribute to an existing metric rather than adding a separate metric to track this.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive enhancement New feature or request receiver/httpcheck HTTP Check receiver Stale
Projects
None yet
Development

No branches or pull requests

2 participants