Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/clickhouse cannot operate without create database, create table permissions #32738

Closed
earwin opened this issue Apr 29, 2024 · 6 comments
Labels
bug Something isn't working exporter/clickhouse needs triage New item requiring triage Stale

Comments

@earwin
Copy link
Contributor

earwin commented Apr 29, 2024

Component(s)

exporter/clickhouse

What happened?

Description

  1. exporter/clickhouse unconditionally runs CREATE DATABASE IF NOT EXISTS, CREATE TABLE IF NOT EXISTS on target DB;
  2. In production environment you normally have service users heavily restricted and all required databases and tables pre-created;
  3. ClickHouse verifies CREATE DATABASE and CREATE TABLE permissions before checking for the db/table presence, so exporter/clickhouse fails with "Not enough privileges" even if CREATE would be a noop.

Collector version

0.99.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@earwin earwin added bug Something isn't working needs triage New item requiring triage labels Apr 29, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mshustov
Copy link

@SpencerTorres should be fixed by #32282?

@SpencerTorres
Copy link
Member

Yes, absolutely fixed by #32282. We can close this @dmitryax 👍

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@SpencerTorres
Copy link
Member

This can be closed @crobert-1

@crobert-1
Copy link
Member

Thanks for following up @SpencerTorres, really appreciate it!

Fixed by #32282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/clickhouse needs triage New item requiring triage Stale
Projects
None yet
Development

No branches or pull requests

4 participants