Timestamp parse failure drops log record

[nslaughter]

Component(s)

receiver/azureeventhub

What happened?

Description

The ResourceLogsUnmarshaler for the Azure records drops them when timestamp parsing fails. This is due to this block in pkg/translator/azure which continues to the next record on timestamp parse failures without appending to log records.

Steps to Reproduce

Run the azureeventhubreceiver and watch warnings in logs while no records are exported.

Expected Result

Log records without timestamps.

Actual Result

No log records.

Collector version

0.94.0

Environment information

Environment

OS: Docker on OSX/AMD
Compiler(if manually compiled): go v1.21.6 (via make docker-otelcontribcol)

OpenTelemetry Collector configuration

receivers:
  azureeventhub:
    connection: ${AZURE_EVENTHUB_CONNECTION} 

exporters:
  otlp:
    endpoint: "${INGEST_ENDPOINT}"
    headers:
        "lightstep-access-token": "${LS_ACCESS_TOKEN}"

processors:
  batch:

service:
  telemetry:
    logs:
  pipelines:
    logs:
      receivers: [azureeventhub]
      processors: [batch]
      exporters: [otlp]

Log output

2024-02-13T18:39:26.651Z	warn	azure@v0.94.0/resourcelogs_to_logs.go:112	Unable to convert timestamp from log	{"kind": "receiver", "name": "azureeventhub", "data_type": "logs", "timestamp": ""}

Additional context

#27589 is related.
We're likely going to do better by parsing to an RFC3339 timestamp instead of ISO8601, but I still believe that the current behavior in the case of parse failures is unexpected and we should change.

[github-actions]

Pinging code owners:

• receiver/azureeventhub: @atoulme @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/azureeventhub: @atoulme @djaglowski @cparkins

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.