[extension/storage/filestorage] fsync should be true by default

[bouk]

Component(s)

extension/storage/filestorage

Describe the issue you're reporting

The bbolt DB.NoSync flag has the following comment:

// Setting the NoSync flag will cause the database to skip fsync()
// calls after each commit. This can be useful when bulk loading data
// into a database and you can restart the bulk load in the event of
// a system failure or database corruption. Do not set this flag for
// normal use.
//
// THIS IS UNSAFE. PLEASE USE WITH CAUTION.

This flag should definitely not be set by default, because it can lead to data loss and database corruption, which will cause otelcol to crash loop.

I suggest we set the default of the fsync config option to true to avoid this footgun.

@djaglowski

Related #20266

[github-actions]

Pinging code owners:

• extension/storage/filestorage: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• extension/storage/filestorage: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.