Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to modify distribution information #29858

Closed
codeboten opened this issue Dec 13, 2023 · 4 comments
Closed

Document how to modify distribution information #29858

codeboten opened this issue Dec 13, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@codeboten
Copy link
Contributor

codeboten commented Dec 13, 2023

Component(s)

No response

Describe the issue you're reporting

It would be great to have a section in CONTRIBUTING.md describing what needs to happen when distributions info are being modified.

@codeboten codeboten added the needs triage New item requiring triage label Dec 13, 2023
@crobert-1 crobert-1 added documentation Improvements or additions to documentation and removed needs triage New item requiring triage labels Dec 13, 2023
@codeboten
Copy link
Contributor Author

Assigning @atoulme as he volunteered to work on it in the collector SIG call 😬

@crobert-1
Copy link
Member

As discussed, it may be good to add another make command that encompasses all of the necessary metadata/code owner updates, but at the bare minimum all of the existing required commands should be documented.

Also, there are specific requirements for the GitHub personal access token (PAT) to be able to successfully run the make update-codeowners, and possibly make gendistributions. Specific information on what access is required for the PAT should be added for these commands.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Feb 12, 2024
@crobert-1 crobert-1 removed the Stale label Feb 26, 2024
@atoulme
Copy link
Contributor

atoulme commented Apr 13, 2024

Closing as no-op

@atoulme atoulme closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants