Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstats] Add k8s.node.rlimit metrics to track max pid and current count #29699

Closed
jinja2 opened this issue Dec 7, 2023 · 4 comments

Comments

@jinja2
Copy link
Contributor

jinja2 commented Dec 7, 2023

Component(s)

receiver/kubeletstats

Is your feature request related to a problem? Please describe.

One of the eviction signals used by kubelet is pid.available (available process identifiers). I'd like to be able to track pid utilization on a host.

Describe the solution you'd like

The /stats/summary api exposes 2 useful metrics to track pids available on a node, node.rlimit.curproc and node.rlimit.maxpid. We should optionally scrape these 2 additional metrics from stats/summary endpoint to allow for tracking of pid utilization.

Describe alternatives you've considered

We could technically get the running processes from the processes scraper of hostmetrics receiver but I did not find metrics for getting the limit which is set to min("/proc/sys/kernel/pid_max", "/proc/sys/kernel/threads-max"). We might consider adding pid_max and threads-max to hostmetrics/processes receiver since these are useful limits to track in general whether running k8s or not.

Additional context

No response

@jinja2 jinja2 added enhancement New feature or request needs triage New item requiring triage labels Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth
Copy link
Member

Seems like a good set of optional metrics. Since it is related to /stats/summary I like doing it in the kubeletstatsreceiver.

@TylerHelmuth TylerHelmuth added priority:p2 Medium and removed needs triage New item requiring triage labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants