Update to latest semantic conventions

[stonkie]

Component(s)

No response

What happened?

Description

Semantic conventions have settled on a slightly different set of properties for HTTP clients than those implemented : https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md#http-client

The main one is using http.url instead of url.full. http.response.status_code should also be used instead of http.status_code

When used with the latest OpenTelemetry.Instrumentation.Http 1.6.0-rc.1 (see this change : open-telemetry/opentelemetry-dotnet#5068), the AppInsight integration is quite bare.

The logic here would need to be updated to take url.full into account : https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/azuremonitorexporter/trace_to_envelope.go

Steps to Reproduce

Instrumented dotnet application with OpenTelemetry.Instrumentation.Http 1.6.0-rc.1 and a collector using the azuremonitorexporter.

Expected Result

Actual Result

Collector version

'otel/opentelemetry-collector-contrib:0.90.1'

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[stonkie]

I managed to work around it using this processor for both requests and dependencies :

      attributes:
        actions:
          - key: http.status_code
            action: insert
            from_attribute: http.response.status_code
          - key: http.url
            action: insert
            from_attribute: url.full
          - key: http.target
            action: insert
            from_attribute: url.path
          - key: http.host
            action: insert
            from_attribute: server.address
          - key: http.scheme
            action: insert
            from_attribute: url.scheme
          - key: http.method
            action: insert
            from_attribute: http.request.method

[github-actions]

Pinging code owners for exporter/azuremonitor: @pcwiese. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Thanks for filing @stonkie, and including references and a temporary workaround!

I looked into this and agree that references to semantic conventions need to be updated. Currently the exporter is at v1.6.1 of semantic conventions, so it should be updated to latest. It may be good also to document in the README the semantic convention version it's on, so users aren't caught off guard like this in the future.

For context, the central method that would need updated is here, but whoever ends up making this change needs to confirm other conversions are up to date as well. The Attribute Mapping section of the exporter's README will also need updated as a part of this change.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/azuremonitor: @pcwiese

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[aygalinc]

I open an MR on repository collector to generate appropriate specification file : open-telemetry/opentelemetry-collector#9593

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/azuremonitor: @pcwiese

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[kamilzzz]

Is there any update on this?

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/azuremonitor: @pcwiese

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[codeboten]

The correct semantic convention attributes are available in the v1.25.0 of the semconv package so making this change should be unblocked

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/azuremonitor: @pcwiese

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.