Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional metric to Mysql receiver #29545

Closed
samiura opened this issue Nov 28, 2023 · 6 comments
Closed

Add additional metric to Mysql receiver #29545

samiura opened this issue Nov 28, 2023 · 6 comments
Labels
enhancement New feature or request receiver/mysql

Comments

@samiura
Copy link
Contributor

samiura commented Nov 28, 2023

Component(s)

receiver/mysql

Is your feature request related to a problem? Please describe.

When monitoring a MySQL database, few useful metrics are the number of qcache hits, qcache not cached, number of queries in qcache in each database. Prior to Mysql 5.7.20 qcache metrics are used hence the need for these metrics

Describe the solution you'd like

The mysql receiver already queries global status variables information. I would add the three additional metrics to the list

Describe alternatives you've considered

No response

Additional context

No response

@samiura samiura added enhancement New feature or request needs triage New item requiring triage labels Nov 28, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski removed the needs triage New item requiring triage label Nov 28, 2023
@djaglowski
Copy link
Member

Prior to Mysql 5.7.20 qcache metrics are used hence the need for these metrics

Am I understanding correctly that these metrics are not available after 5.7.20?

@samiura
Copy link
Contributor Author

samiura commented Nov 29, 2023

@djaglowski yes correct.

@djaglowski
Copy link
Member

@samiura, 5.7 was recently deprecated and we claim support for 8.0+, so I think we shouldn't add these metrics.

The sqlquery receiver should be able to handle these though, so I'd recommend using that instead. It might be worth adding an example configuration here.

@samiura
Copy link
Contributor Author

samiura commented Nov 29, 2023

@djaglowski I understand that and I will close the PR.

@atoulme
Copy link
Contributor

atoulme commented Dec 13, 2023

Closing this issue as not planned as the enhancement was rejected as MySQL 5.7 is not supported.

@atoulme atoulme closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/mysql
Projects
None yet
Development

No branches or pull requests

3 participants