Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double-star mutli-level directory glob matching to filelog receiver #2329

Closed
djaglowski opened this issue Feb 11, 2021 · 5 comments · Fixed by open-telemetry/opentelemetry-log-collection#97
Closed

Add double-star mutli-level directory glob matching to filelog receiver #2329

djaglowski opened this issue Feb 11, 2021 · 5 comments · Fixed by open-telemetry/opentelemetry-log-collection#97
Assignees
@pmalek-sumo
Labels
spec:logs
Milestone
Basic Logs Support

Comments

@djaglowski
Copy link
Member

No description provided.

@djaglowski djaglowski mentioned this issue Feb 11, 2021
Closed
18 tasks
@pmalek-sumo
Copy link
Contributor

I can pick this one up if no one is working on this yet.

I believe this boils down to

Would that be correct?

I'd suggest to use an already existing package for glob patterns with double asterisks like e.g. https://github.com/bmatcuk/doublestar

@djaglowski
Copy link
Member Author

@pmalek-sumo That looks correct to me. Thanks for picking this up!

@tigrannajaryan tigrannajaryan added this to the Basic Logs Support milestone Mar 3, 2021
kisieland referenced this issue in kisieland/opentelemetry-collector-contrib Mar 16, 2021
@dependabot
Bump github.com/google/uuid from 1.1.3 to 1.1.4 (#2329)
0bfa1ce 
Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.1.3 to 1.1.4.
- [Release notes](https://github.com/google/uuid/releases)
- [Commits](google/uuid@v1.1.3...v1.1.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pmalek-sumo pmalek-sumo mentioned this issue Apr 12, 2021
Merged
@pmalek-sumo
Copy link
Contributor

@djaglowski I've pushed this change: open-telemetry/opentelemetry-log-collection#97

Let me know if I've missed anything. Testing this in contrib with opentelemetry-log-collection@v0.17.0+this patch worked for me.

@djaglowski djaglowski reopened this Apr 12, 2021
@djaglowski
Copy link
Member Author

Leaving this open until the dependency is on main.

@djaglowski
Copy link
Member Author

Resolved by #3369

ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@MrAlias @Aneurysm9
Use the grpc.ClientConn to handle connections for the otlptracegrpc c…
f1971b3 
…lient (#2329)

* POC using the grpc.ClientConn to handle connections

* Update invalid client security test

* Update client start test for a bad endpoint

* Use any ClientConn a user provides

* Connect ReconnectionPeriod to gRPC conn retries

* Replace connection retry handling direct in otlptracegrpc

* Fix client comments

* Fix comment for NewGRPCConfig

* Replace reconnection test

* Fix grammar

* Remove unrelated changes

* Remove connection pkg

* Rename evaluate to retryable

* POC using the grpc.ClientConn to handle connections

* Replace connection retry handling direct in otlptracegrpc

* Add ClientConn use changes to changelog

* Update otlptracegrpc options

* Only close ClientConn that the Client create

* Remove listener wrapper from mock_collector_test

This is not needed now that no tests relies on the listener to wait for
a connection to be established before continuing.

* Fix spelling error

* Do not use deprecated options in the otel-collector example

* Add unit tests for retryable and throttleDelay funcs

* Add unit tests for context heredity

* Add test that exporter stop is linked to context cancel

* go mod tidy

* Update exporters/otlp/otlptrace/otlptracegrpc/client.go

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Fix go.mod from rebase

* Remove wrong comment about client stop closing gRPC conn

* Fix shutdown test cleanup

Do not check the second call to the client Stop. There is no guarantee
it will not error in normal operation.

* Make lint fixes

* Fix flaky unit test

Use the internals of the client to explicit cancel the context returned
from exportContext. This gets around the bug where the select in Stop
may randomly choose the non-context Done case and avoid returning an
error (also failing to cancel the context).

* Remove deprecation

To configure the client/exporter with environment variables these
options are used. There is no way to fully remove these options without
removing support for configuration with environment variables. Leave
that decision and strategy determination to a separate PR.

* Fix grammatical error in comment

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmalek-sumo pmalek-sumo

Labels
spec:logs
Projects
None yet
Milestone
Basic Logs Support
3 participants
@tigrannajaryan @djaglowski @pmalek-sumo