Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kafka] Consume metrics published by Telegraf #23181

Closed
ledor473 opened this issue Jun 6, 2023 · 7 comments
Closed

[receiver/kafka] Consume metrics published by Telegraf #23181

ledor473 opened this issue Jun 6, 2023 · 7 comments

Comments

@ledor473
Copy link
Contributor

ledor473 commented Jun 6, 2023

Component(s)

receiver/kafka

Is your feature request related to a problem? Please describe.

Currently, my metrics are collected using Telegraf and then sent to Kafka using Kafka output plugin. It's then consumed by another set of Telegraf that will write it to the storage layer.
I'd like to use a few features of the OpenTelemetry Collector but need to move to it in a phased manner. The plan would be to have the OpenTelemetry Collector consume the same messages that are published by Telegraf (using a different consumer group) and from there use the wanted features.

Describe the solution you'd like

Add a new Telegraf to the unmarshalers supported by receiver/kafka.
I'm thinking it could support only the influx format at first. Since Telegraf supports various formats, it might be best to take that into consideration while adding the features.

Describe alternatives you've considered

I looked into having Telegraf publish directly in OTLP format but it doesn't seem to be possible based on the output formats documentation.
I also looked into the OpenTelemetry output plugin, but it would skip Kafka which isn't ideal for my use case.

Additional context

Ultimately, if there's little interest in this feature request, I think I can still make it work by building an OpenTelemetry Collector and manually invoking the WithMetricsUnmarshalers method. But I figured that Telegraf is common enough that it might be interesting to host it here.

@ledor473 ledor473 added enhancement New feature or request needs triage New item requiring triage labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ledor473 ledor473 changed the title Consume Telegraf metrics [receiver/kafka] Consume metrics published by Telegraf Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • receiver/kafka: @pavolloffay @MovieStoreGuy
  • needs: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Sep 9, 2023

@ledor473 would you like to work on this?

@github-actions github-actions bot removed the Stale label Sep 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 9, 2023
@atoulme
Copy link
Contributor

atoulme commented Nov 10, 2023

@ledor473 are you offering to make this contribution? We are moving encodings to extensions, so they can be reused across components. See https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/encoding

@github-actions github-actions bot removed the Stale label Nov 11, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 11, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants