Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f5cloudexporter: Add User-Agent header with version to requests #2291

Closed
gramidt opened this issue Feb 7, 2021 · 5 comments
Closed

f5cloudexporter: Add User-Agent header with version to requests #2291

gramidt opened this issue Feb 7, 2021 · 5 comments
Assignees
@gramidt
Labels
exporter/f5cloud F5 exporter Stale

Comments

@gramidt
Copy link
Member

gramidt commented Feb 7, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
We would like to know what version/build of collector is making requests.

Describe the solution you'd like
Set 'User-Agent' header with value of 'opentelemetry-collector-contrib VERSION' when not provided by user in config.

Describe alternatives you've considered

  • Just have users set the 'User-Agent' to this suggested value when they configure the collector. (Not reliable)

Additional context
A PR will follow shortly with the implementation.
@gramidt gramidt changed the title f5cloudexporter: Add agent header with version to requests f5cloudexporter: Add User-Agent header with version to requests Feb 7, 2021
@gramidt gramidt mentioned this issue Feb 7, 2021
Merged
@gramidt
Copy link
Member Author

gramidt commented Feb 7, 2021

@andrewhsu - Could you assign this to me?

@gramidt
Copy link
Member Author

gramidt commented Feb 11, 2021

This just needs the proper labels and can be closed.

@gramidt
Copy link
Member Author

gramidt commented Feb 14, 2021

@andrewhsu @bogdandrutu - This just needs to the proper labels for tracking and can be closed, since the PR was merged.

@gramidt
Copy link
Member Author

gramidt commented Feb 20, 2021

@bogdandrutu - Could you add the proper labels for tracking? Once added, I will close the issue.

kisieland referenced this issue in kisieland/opentelemetry-collector-contrib Mar 16, 2021
Migrate CircleCI build-and-test workflow to GitHub Actions (1/3) (#2291)
6196bd8 
* GitHub Actions: adding
windows-test,check-links,setup-environment,lint,cross-compile

* moving check-links out of main workflow to make it non blocking for releases
@alolita alolita added the exporter/f5cloud F5 exporter label Sep 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@atoulme atoulme closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gramidt gramidt

Labels
exporter/f5cloud F5 exporter Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atoulme @gramidt @alolita