Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.19 sync/atomic wrappers instead of go.uber.org/atomic #18456

Closed
mx-psi opened this issue Feb 8, 2023 · 3 comments · Fixed by #19385
Closed

Use Go 1.19 sync/atomic wrappers instead of go.uber.org/atomic #18456

mx-psi opened this issue Feb 8, 2023 · 3 comments · Fixed by #19385
Assignees
@dubonzi
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request good first issue Good for newcomers priority:p2 Medium

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 8, 2023

Component(s)

No response

Describe the issue you're reporting

Go 1.19 includes new builtin atomic wrappers that can replace the usage of go.uber.org/atomic. We should switch to using these and ban the usage of go.uber.org/atomic via depguard (basically, inverting this).

Counterpart of open-telemetry/opentelemetry-collector/issues/7160.

This is blocked by #18454
@mx-psi mx-psi added enhancement New feature or request good first issue Good for newcomers priority:p2 Medium ci-cd CI, CD, testing, build issues on hold This is blocked by another PR/issue and removed on hold This is blocked by another PR/issue labels Feb 8, 2023
@mx-psi
Copy link
Member Author

mx-psi commented Feb 15, 2023

This is now unblocked

@dubonzi
Copy link
Contributor

dubonzi commented Mar 7, 2023

Hi @mx-psi, can I work on this?

@mx-psi
Copy link
Member Author

mx-psi commented Mar 7, 2023

@dubonzi sure, feel free to take a look at open-telemetry/opentelemetry-collector/pull/7220 for inspiration

@dubonzi dubonzi mentioned this issue Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dubonzi dubonzi

Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request good first issue Good for newcomers priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace go.uber.org/atomic with sync/atomic dubonzi/opentelemetry-collector-contrib
2 participants
@dubonzi @mx-psi