Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/jaegerremotesampling] Misleading implementation on two endpoints #18058

Closed
yurishkuro opened this issue Jan 26, 2023 · 4 comments · Fixed by #18070
Closed

[extension/jaegerremotesampling] Misleading implementation on two endpoints #18058

yurishkuro opened this issue Jan 26, 2023 · 4 comments · Fixed by #18070
Assignees
Labels

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jan 26, 2023

Component(s)

extension/jaegerremotesampling

What happened?

Description

This extension serves the same output on two HTTP endpoints / and /sampling, which presumably was meant to emulate the Jaeger Agent's behavior. However, in the Jaeger Agent the / endpoint returns a legacy format (see https://www.jaegertracing.io/docs/1.41/apis/#remote-sampling-configuration-stable).

This difference either needs to be called out in the README or fixed (although returning legacy format from this extension does not make sense, I'd rather it did not support this endpoint).

Collector version

0.70.0

Environment information

Environment

any

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@yurishkuro yurishkuro added bug Something isn't working needs triage New item requiring triage labels Jan 26, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

@frzifus, are you able to handle this?

@frzifus
Copy link
Member

frzifus commented Jan 26, 2023

Sure, i will have a more detailed view next week.

@yurishkuro
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants