Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Failing Windows unit tests do not cause the job to fail #17181

Closed
dmitryax opened this issue Dec 20, 2022 · 6 comments
Closed

[CI] Failing Windows unit tests do not cause the job to fail #17181

dmitryax opened this issue Dec 20, 2022 · 6 comments
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues help wanted Extra attention is needed priority:p1 High

Comments

@dmitryax
Copy link
Member

dmitryax commented Dec 20, 2022

It looks like #17037 was solved only for Linux.

Windows tests are still silently failing. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3744658264/jobs/6358274789 with the following errors:

--- FAIL: TestFileTracesReceiver (1.01s)
=== RUN   TestFileMetricsReceiver
if [ "true" = "true" ]; then \
	go test -race -timeout 300s --tags="" -v ./... 2>&1 | tee -a ./foresight-test-report.txt; \
else \
	go test -race -timeout 300s --tags="" ./...; \
fi
    file_test.go:93: 
        	Error Trace:	D:\a\opentelemetry-collector-contrib\opentelemetry-collector-contrib\receiver\otlpjsonfilereceiver\file_test.go:93
        	Error:      	"[]" should have 1 item(s), but has 0
        	Test:       	TestFileMetricsReceiver
--- FAIL: TestFileMetricsReceiver (1.00s)
=== RUN   TestFileLogsReceiver
    file_test.go:119: 
        	Error Trace:	D:\a\opentelemetry-collector-contrib\opentelemetry-collector-contrib\receiver\otlpjsonfilereceiver\file_test.go:119
        	Error:      	"[]" should have 1 item(s), but has 0
        	Test:       	TestFileLogsReceiver
--- FAIL: TestFileLogsReceiver (1.02s)
=== RUN   TestLoadConfig
--- PASS: TestLoadConfig (0.00s)
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/otlpjsonfilereceiver	3.124s
FAIL
@dmitryax dmitryax added bug Something isn't working priority:p1 High ci-cd CI, CD, testing, build issues help wanted Extra attention is needed labels Dec 20, 2022
@dmitryax
Copy link
Member Author

dmitryax commented Dec 20, 2022

cc @MovieStoreGuy in case you know how to apply your fix on Windows.

Otherwise, we can vote to remove Foresight. I played with it but didn't find it super helpful.

@dmitryax dmitryax changed the title [CI] Failing Windows unit tests do cause the job to fail [CI] Failing Windows unit tests do not cause the job to fail Dec 20, 2022
@MovieStoreGuy
Copy link
Contributor

Do you have a link to the action that failed? Sorry just need a bit more information of the environment to help understand the setup.

@dmitryax
Copy link
Member Author

dmitryax commented Dec 20, 2022

Yes, the job with silently failing tests is in the description https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3744658264/jobs/6358274789

@MovieStoreGuy
Copy link
Contributor

Yes, the job with silently failing tests is in the description https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3744658264/jobs/6358274789

I will say I am still waking up and leave it at that... :disappears:

@MovieStoreGuy
Copy link
Contributor

MovieStoreGuy commented Dec 21, 2022

I am trying to test something here #17183 but it appears the windows steps are skipped and I am not sure why.

Nevermind I saw the check for labels.

@dmitryax
Copy link
Member Author

Fixed by #17183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues help wanted Extra attention is needed priority:p1 High
Projects
None yet
Development

No branches or pull requests

2 participants