-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Failing Windows unit tests do not cause the job to fail #17181
Comments
cc @MovieStoreGuy in case you know how to apply your fix on Windows. Otherwise, we can vote to remove Foresight. I played with it but didn't find it super helpful. |
Do you have a link to the action that failed? Sorry just need a bit more information of the environment to help understand the setup. |
Yes, the job with silently failing tests is in the description https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3744658264/jobs/6358274789 |
I will say I am still waking up and leave it at that... :disappears: |
I am trying to test something here #17183 but it appears the windows steps are skipped and I am not sure why. Nevermind I saw the check for labels. |
Fixed by #17183 |
It looks like #17037 was solved only for Linux.
Windows tests are still silently failing. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3744658264/jobs/6358274789 with the following errors:
The text was updated successfully, but these errors were encountered: