-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processor/resourcedetectionprocessor: add fall back method for GKE host name detection #15716
Comments
Pinging code owners: @jrcamp @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@dashpole We want your feedback on this. On GKE, |
Generally, I'd like the It should not query the Kubernetes API Server. It is already possible to use the downward API today with the |
That's fair, I understand. Even if we don't do it automatically, I think it would still be helpful to at least document the limitation on Workload identity and suggest using the |
I fully support improving documentation :) |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Is your feature request related to a problem? Please describe.
When using Workload Identity in GKE, the host name resolution will fail, resulting in an empty host name attribute.
Describe the solution you'd like
Under normal circumstances, this call returns the instance name. When not available, one could fall back to obtaining the Kubernetes node name from the Kubernetes API (with
k8s.io/client-go
). The Kubernetes node name is also equal to the instance name.The text was updated successfully, but these errors were encountered: