Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awscloudwatch] Named config validation failing due to default config #14952

Closed
schmikei opened this issue Oct 14, 2022 · 0 comments · Fixed by #14953
Closed

[receiver/awscloudwatch] Named config validation failing due to default config #14952

schmikei opened this issue Oct 14, 2022 · 0 comments · Fixed by #14953
Assignees
Labels
bug Something isn't working priority:p2 Medium

Comments

@schmikei
Copy link
Contributor

What happened?

Description

validation for named configs will not work as expected as the createDefaultConfig creates a non-nil autodiscover config.

I think for now we should remove the validation check as it is handled later on.

Steps to Reproduce

Expected Result

Actual Result

Collector version

v0.62.0

Environment information

Environment

OS: Darwin
Compiler(if manually compiled): go 18.5

OpenTelemetry Collector configuration

profile: 'kschmitt'
    region: us-east-2
    logs:
      poll_interval: 10s
      groups:
        autodiscover: null
        named:
          /aws/eks/dev-eks-0/cluster:
            names: [kube-apiserver-audit-ea9c831555adca1815ae04b884b30566]

Log output

2022-10-14 09:55:17.414048 I | collector server run finished with error: failed to get config: invalid configuration: receiver "awscloudwatch" has invalid configuration: both autodiscover and named configs are configured, Only one or the other is permitted

Additional context

i will submit a PR for this shortly

@schmikei schmikei added bug Something isn't working needs triage New item requiring triage labels Oct 14, 2022
@schmikei schmikei changed the title [receiver/awscloudwatch] [receiver/awscloudwatch] Named config validation failing due to default config Oct 14, 2022
@evan-bradley evan-bradley added priority:p2 Medium and removed needs triage New item requiring triage labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants