Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/servicegraphprocessor] Not included in the v0.61.0 release image #14899

Closed
sherifkayad opened this issue Oct 12, 2022 · 4 comments
Closed
Labels
priority:p2 Medium processor/servicegraph Service graph processor question Further information is requested Stale

Comments

@sherifkayad
Copy link

What happened?

Description

It seems like the Service Graph Processor (https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/servicegraphprocessor) isn't included in the contrib distro. Is that by mistake? Was that intentional?

I think it should be included as it's officially released in the contrib source code since v0.60.0 (https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.60.0)

With image version 0.61.0 of the contrib collector I am getting:

collector server run finished with error: failed to get config: cannot unmarshal the configuration: unknown processors type \"servicegraph\" for \"servicegraph\" (valid values: [cumulativetodelta resourcedetection resource memory_limiter attributes k8sattributes experimental_metricsgeneration probabilistic_sampler spanmetrics transform batch deltatorate filter groupbytrace metricstransform span groupbyattrs redaction routing tail_sampling])\n

Steps to Reproduce

Expected Result

The servicegraph processor is available and can be configured

Actual Result

Collector version

v0.61.0

Environment information

Environment

Docker / Kubernetes

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

I also filed open-telemetry/opentelemetry-collector-releases#217 as I wasn't sure where the issue should be addressed

@sherifkayad sherifkayad added bug Something isn't working needs triage New item requiring triage labels Oct 12, 2022
@evan-bradley evan-bradley added question Further information is requested priority:p2 Medium processor/servicegraph Service graph processor and removed bug Something isn't working needs triage New item requiring triage labels Oct 12, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @jpkrohling @mapno. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mapno
Copy link
Contributor

mapno commented Oct 13, 2022

I missed this when I first merged the processor. Thanks for reporting. Opened this PR to included in future builds: #14932

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 13, 2022
@fatsheep9146
Copy link
Contributor

fatsheep9146 commented Dec 13, 2022

I think this issue is solved by #14392.

cc @jpkrohling @mapno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Medium processor/servicegraph Service graph processor question Further information is requested Stale
Projects
None yet
Development

No branches or pull requests

4 participants