Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/telemetryquerylanguage] Change NewParser signature to have a list of Options #13759

Closed
kentquirk opened this issue Aug 31, 2022 · 4 comments
Assignees

Comments

@kentquirk
Copy link
Member

Is your feature request related to a problem? Please describe.
We expect that that Parser object will need to change over time, and we want the signature of NewParser to be stable over time, so we would like to convert the signature of NewParser to have a variadic list of ParserOptions, each of which can modify a parser. This way, new features wouldn't require existing consumers of NewParser to change when the Parser grows new capabilities.

Describe alternatives you've considered
Not doing this means that future changes are more costly, because they would require breaking changes or awkward defaults.

Additional context
See discussion in #13544

@TylerHelmuth TylerHelmuth changed the title Change NewParser signature to have a list of Options [pkg/telemetryquerylanguage] Change NewParser signature to have a list of Options Aug 31, 2022
@kovrus
Copy link
Member

kovrus commented Nov 9, 2022

@TylerHelmuth @kentquirk if you are not working on it do you mind assigning it to me?

@TylerHelmuth TylerHelmuth assigned kovrus and unassigned kentquirk Nov 9, 2022
@TylerHelmuth
Copy link
Member

@kovrus its yours.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@kovrus
Copy link
Member

kovrus commented Feb 7, 2023

Resolved by #17394

@kovrus kovrus closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants