Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs derived metrics processor #13530

Closed
yeya24 opened this issue Aug 23, 2022 · 15 comments
Closed

Logs derived metrics processor #13530

yeya24 opened this issue Aug 23, 2022 · 15 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Aug 23, 2022

Is your feature request related to a problem? Please describe.

I'd like to have the ability to derive metrics from incoming logs so that the calculated metrics can be exported using metrics exporters.

This ability is very similar to spanmetricsprocessor and Promtail metrics stage https://grafana.com/docs/loki/latest/clients/promtail/stages/metrics/.

Describe the solution you'd like

Have a new processor to create metrics from logs based on the configuration.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Why not use Promtail directly?

Promtail works well for this usecase but it is bound to Loki and it is AGPL.

@TylerHelmuth
Copy link
Member

@yeya24 can you open a new issue that uses the New Component template for this ask?

@yeya24
Copy link
Contributor Author

yeya24 commented Aug 26, 2022

@TylerHelmuth Sure, I'd love to. This issue is mainly to gather some feedbacks first as I am not sure if someone from the Otel team would love to sponsor it.

@evan-bradley
Copy link
Contributor

@yeya24 If you open a new issue with the New Component template, it would make it easier for potential sponsors to review your proposal and determine who might be able to sponsor it.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 10, 2022
@jpkrohling
Copy link
Member

Was a new issue created for this? I have talked about this with different people, like @djaglowski, @kovrus and @mar4uk, and I think this would be great to have once the connectors feature is implemented.

@github-actions github-actions bot removed the Stale label May 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@wbh1
Copy link
Contributor

wbh1 commented Jul 26, 2023

I'm unable to find a new issue created for this, but it is still a useful idea that could replace usage of mtail in my experience.

@github-actions github-actions bot removed the Stale label Jul 27, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Sep 26, 2023
@wbh1
Copy link
Contributor

wbh1 commented Sep 26, 2023

This is still something that I think would be useful. Maybe metricsgenerationprocessor could be expanded to operate on logs, too?

@github-actions github-actions bot removed the Stale label Sep 27, 2023
@jpkrohling
Copy link
Member

We have a span metrics connector, which would likely be a better source of inspiration for this. Would you like to give it a try?

@yeya24
Copy link
Contributor Author

yeya24 commented Oct 23, 2023

Indeed it looks good to reuse the connector pattern for this one

@atoulme
Copy link
Contributor

atoulme commented Dec 6, 2023

@bdschaap
Copy link

bdschaap commented Jan 12, 2024

I think the countconnector may satisfy some use cases for converting logs to metrics. However, if I have logs that are essentially measurement values with name/value pairs in them then I'd like to convert those to metrics and export them to a metrics exporter. For example, if I have a measurement that contains an elapsed duration then I would want to use that value for the metric (rather than a count of those measurements).

@cwegener
Copy link
Contributor

A 'New Component' issue was actually created at some point, but not linked back to this discussion. Here it is: #18269

@djaglowski
Copy link
Member

Since this issue overlaps with #18269, and we eventually need a formal "New Component" issue for the idea, I'm closing this on in favor of the other. Please continue discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants