Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build was hard code to amd64 for docker build #11873

Closed
gyliu513 opened this issue Jul 1, 2022 · 8 comments · Fixed by #12217
Closed

The build was hard code to amd64 for docker build #11873

gyliu513 opened this issue Jul 1, 2022 · 8 comments · Fixed by #12217
Assignees
Labels
ci-cd CI, CD, testing, build issues closed as inactive enhancement New feature or request priority:p3 Lowest Stale

Comments

@gyliu513
Copy link
Member

gyliu513 commented Jul 1, 2022

Describe the bug
A clear and concise description of what the bug is.

After I run make docker-otelcontribcol on my mac, I found the binary name was otelcontribcol_linux_amd64, seems the makefile is hardcoding the GOARCH as amd64 https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/Makefile#L241 , any reason why? Thanks!

Steps to reproduce
If possible, provide a recipe for reproducing the error.

What did you expect to see?
A clear and concise description of what you expected to see.

What did you see instead?
A clear and concise description of what you saw instead.

What version did you use?
Version: (e.g., v0.4.0, 1eb551b, etc)

What config did you use?
Config: (e.g. the yaml config file)

Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Additional context
Add any other context about the problem here.

@gyliu513 gyliu513 added the bug Something isn't working label Jul 1, 2022
@codeboten
Copy link
Contributor

I think the docker make target is intended specifically to build a collector to run inside a container, make otelcontribcol is the target used to compile locally.

@gyliu513
Copy link
Member Author

gyliu513 commented Jul 5, 2022

Thanks @codeboten , but still have a question: why hardcoding docker build to amd64? With docker build, it should also support multi-arch as well.

@codeboten
Copy link
Contributor

It's a good question, based on git blame it looks like the decision was made over 2 years ago. I'm not sure why

@gyliu513 gyliu513 changed the title The build was hard code to amd64 The build was hard code to amd64 for docker build Jul 5, 2022
@TylerHelmuth
Copy link
Member

@gyliu513 Are you free to update the docker-otelcontribcol target to support more architectures?

@gyliu513
Copy link
Member Author

gyliu513 commented Jul 8, 2022

@TylerHelmuth Yes, glad to help. Will fix early next week.

@dmitryax
Copy link
Member

dmitryax commented Aug 10, 2022

#12217 doesn't seem like introduced multi arch image creation

@dmitryax dmitryax removed the bug Something isn't working label Aug 10, 2022
@evan-bradley evan-bradley added enhancement New feature or request priority:p3 Lowest ci-cd CI, CD, testing, build issues labels Sep 16, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 16, 2022
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues closed as inactive enhancement New feature or request priority:p3 Lowest Stale
Projects
None yet
5 participants