Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/scrapertest] Add plog.Log comparison and golden functions #10896

Closed
BinaryFissionGames opened this issue Jun 10, 2022 · 4 comments
Closed

[internal/scrapertest] Add plog.Log comparison and golden functions #10896

BinaryFissionGames opened this issue Jun 10, 2022 · 4 comments
Assignees
@jackycsl
Labels
enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest

Comments

@BinaryFissionGames
Copy link
Contributor

BinaryFissionGames commented Jun 10, 2022 •
edited
Loading

The scrapertest package contains functions for comparing metrics, which is very useful when writing tests.

We should extend this package to also include similar functions for logs (ReadLogs, WriteLogs, and CompareLogs).

This package should also be renamed to clarify that it's useful beyond testing metric scrapers.

See: #10854 (comment)
@BinaryFissionGames BinaryFissionGames mentioned this issue Jun 10, 2022
Merged
@djaglowski djaglowski added priority:p3 Lowest enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 17, 2022
@SergeyParamoshkin
Copy link
Contributor

@djaglowski I try solve this, but I need help with tests

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 9, 2022
@djaglowski djaglowski added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Nov 9, 2022
@jackycsl
Copy link
Contributor

Can you please assign me to this issue?

@fatsheep9146
Copy link
Contributor

Thanks! It's yours! @jackycsl

@fatsheep9146 fatsheep9146 removed help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed labels Dec 10, 2022
@jackycsl jackycsl mentioned this issue Dec 19, 2022
Merged
@dmitryax dmitryax closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackycsl jackycsl

Labels
enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@SergeyParamoshkin @djaglowski @jackycsl @dmitryax @BinaryFissionGames @fatsheep9146