From 481e52409302e798b718e7e69c012a5eb126cb29 Mon Sep 17 00:00:00 2001 From: Dmitrii Anoshin Date: Tue, 10 Jan 2023 14:36:46 -0500 Subject: [PATCH] [pkg/stanza/adapter] Deprecate ConvertFrom (#17494) Similar to Convert, the API is not being used and shouldn't be exported. --- pkg/stanza/adapter/converter.go | 2 +- pkg/stanza/adapter/frompdataconverter.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/stanza/adapter/converter.go b/pkg/stanza/adapter/converter.go index 292d1b847091..de0d16b51a48 100644 --- a/pkg/stanza/adapter/converter.go +++ b/pkg/stanza/adapter/converter.go @@ -288,7 +288,7 @@ func convert(ent *entry.Entry) plog.LogRecord { // Convert converts one entry.Entry into plog.Logs. // To be used in a stateless setting like tests where ease of use is more // important than performance or throughput. -// Deprecated: [v0.68.0] Unnecessary exported API. +// Deprecated: [v0.68.0] Unnecessarily exported API. // Please add a comment in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/17429 // if you use it. func Convert(ent *entry.Entry) plog.Logs { diff --git a/pkg/stanza/adapter/frompdataconverter.go b/pkg/stanza/adapter/frompdataconverter.go index abb5ee2d5b3d..e7703d82cdc7 100644 --- a/pkg/stanza/adapter/frompdataconverter.go +++ b/pkg/stanza/adapter/frompdataconverter.go @@ -176,6 +176,9 @@ func convertFromLogs(workerItem fromConverterWorkerItem) []*entry.Entry { // ConvertFrom converts plog.Logs into a slice of entry.Entry // To be used in a stateless setting like tests where ease of use is more // important than performance or throughput. +// Deprecated: [v0.69.0] Unnecessarily exported API. +// Please add a comment in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/17429 +// if you use it. func ConvertFrom(pLogs plog.Logs) []*entry.Entry { result := make([]*entry.Entry, 0, pLogs.LogRecordCount()) for i := 0; i < pLogs.ResourceLogs().Len(); i++ {