Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client and server docs #137

Conversation

fatsheep9146
Copy link

partly fix #100

Signed-off-by: Ziqi Zhao zhaoziqi9146@gmail.com

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146 fatsheep9146 requested a review from a team October 18, 2022 05:53
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 75.05% // Head: 76.22% // Increases project coverage by +1.17% 🎉

Coverage data is based on head (e5692f0) compared to base (7462bc8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   75.05%   76.22%   +1.17%     
==========================================
  Files          23       23              
  Lines        1792     1792              
==========================================
+ Hits         1345     1366      +21     
+ Misses        334      319      -15     
+ Partials      113      107       -6     
Impacted Files Coverage Δ
client/wsclient.go 87.19% <ø> (ø)
server/serverimpl.go 58.37% <ø> (ø)
client/internal/receivedprocessor.go 84.28% <0.00%> (+15.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fatsheep9146

Comments in the form "X implements Y" don't seem to add much value. @open-telemetry/opamp-go-approvers what do you think?

@tigrannajaryan tigrannajaryan changed the title update client and server docs Update client and server docs Oct 18, 2022
@tigrannajaryan
Copy link
Member

Closing since there is no response on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure all exporter funcs and types have docs
2 participants