Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERD Logic needs refactoring #135

Open
1 task
lovelyjoy1991 opened this issue Jun 7, 2024 · 0 comments
Open
1 task

ERD Logic needs refactoring #135

lovelyjoy1991 opened this issue Jun 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lovelyjoy1991
Copy link
Contributor

Problem

Currently, the frontend is sending back a big bundle of all the operations done in the frontend ERD Table. This ERD table object is divided by add, drop, and alter. All the add operations will execute first then drop, then alter. This logic was BAD.

Solution

Need redesign frontend to send back "sequental" operations instead of bundling operations by add, drop, alter. Because it takes care of multiple edge cases and users in the front can do as many operations they want to ensure SAVE works.
Previous team has illustrated the problem below. The current backend has been written out already. Next step, need to make sure the frontend is sending back the appropriate logic.
image
This is written at backend/src/ipcHandlers/dbCRUDHandlerERD.ts and will replace backend/src/ipcHandlers/dbCRUDHandler.ts when this is ready

Additional information

No response

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd love to make a PR to implement this feature!
@lovelyjoy1991 lovelyjoy1991 added the enhancement New feature or request label Jun 7, 2024
@lovelyjoy1991 lovelyjoy1991 changed the title ERD Logic needs refactory ERD Logic needs refactor Jun 7, 2024
@lovelyjoy1991 lovelyjoy1991 changed the title ERD Logic needs refactor ERD Logic needs refactoring Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant