Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum required pandas version to 0.21.0 #1781

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Change minimum required pandas version to 0.21.0 #1781

merged 1 commit into from
Dec 20, 2017

Conversation

martinholmer
Copy link
Collaborator

This pull request increases from 0.20.1 to 0.21.0 the minimum required version of pandas.

This change is required for the new reforms test (see revisions in the test_reform_json_and_output function that are part of pull request #1766), which use the mapper argument of the pandas.rename method that was first added in pandas version 0.21. Thanks to @derrickchoe, who was using an older version of pandas, for pointing this out.

The unit tests will fail unless you upgrade using this command: conda update pandas

@codecov-io
Copy link

Codecov Report

Merging #1781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1781   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3028    3028           
======================================
  Hits         3028    3028

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e319125...512d1f2. Read the comment docs.

@derrickchoe
Copy link
Contributor

derrickchoe commented Dec 20, 2017

@martinholmer

Thanks for letting me know-- I've updated my version of pandas.

Edit:

I've re-run the tests, and the only current issues are with test_pufcsv.py and test_puf_var_stats.py

I appreciate your identifying the issue with my pandas version so quickly!

@martinholmer martinholmer merged commit 9b13a70 into PSLmodels:master Dec 20, 2017
@martinholmer martinholmer deleted the upgrade-pandas-version branch December 23, 2017 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants