-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stats summary script #1566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 2644 2732 +88
======================================
+ Hits 2644 2732 +88
Continue to review full report at Codecov.
|
@martinholmer this PR fixed the |
@Amy-Xu, When I download pull request #1566 to my computer and do the two runs, I get the same results in the |
@Amy-Xu, I haven't studied the code in the |
@martinholmer Thanks for the review. I'll round all results to three decimal points. In terms of generating both files at the same time, the original thought was simply that users may just be interested in one of them so it would be the most convenient for users to produce one a time. Since we also need to update the files, it makes sense to me producing both at the same time. I'll revise the code accordingly. |
@Amy-Xu said:
Thanks. |
@Amy-Xu, Thanks for this update. Look good, so I'll merge it now. |
This script has been updated to work with the latest version of Tax-Calculator. Output files get updated as well. Thanks to Martin for pointing out in issue #1562.