Add ce_aftertax_income() utility function and test #1098
Conversation
Current coverage is 98.83% (diff: 100%)@@ master #1098 diff @@
==========================================
Files 38 38
Lines 2830 2931 +101
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2796 2897 +101
Misses 34 34
Partials 0 0
|
| @@ -50,7 +50,7 @@ py.test -m "not requires_pufcsv" | |||
| ``` | |||
|
|
|||
| This will start executing a pytest suite containing about 300 tests, | |||
| but will skip the few tests that require the `puf.csv` file as input. | |||
| but will skip the three tests that require the `puf.csv` file as input. | |||
There was a problem hiding this comment.
Should we really specify the exact number of tests in this document? We'll have to constantly update them, and the actual count is easily deducible for someone running py.test.
There was a problem hiding this comment.
Thanks for the tip.
| Depending on your computer, the execution time for this complete suite | ||
| of unit tests is roughly three minutes. | ||
| of unit tests is roughly four minutes. |
There was a problem hiding this comment.
Same point here - remove frequently changing numbers from documentation.
There was a problem hiding this comment.
Thanks for the tip.
|
I would like to merge pull request #1098 when I return to my office in a week on Wed, Dec. 21. @MattHJensen @feenberg @Amy-Xu @GoFroggyRun @andersonfrailey @zrisher @codykallen |
|
@martinholmer, this looks great. +1 |
The pull request implements as an optional utility function the kind of expected-utility normative welfare analysis discussed in issue #1050, which was raised by @gleiserson (Greg Leiserson).
This pull request also adds to the
inctax.pycommand-line inteface to Tax-Calculator an option called--ceeuthat uses the new utility function to compute certainty-equivalent expected-utility results for the specified reform.Comments and suggestions are welcome.
@MattHJensen @feenberg @Amy-Xu @GoFroggyRun @andersonfrailey @zrisher @codykallen