Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Python is not in the list #1273

Closed
bdougie opened this issue Jun 17, 2023 · 9 comments · Fixed by #1283
Closed

bug: Python is not in the list #1273

bdougie opened this issue Jun 17, 2023 · 9 comments · Fixed by #1283
Assignees
Labels

Comments

@bdougie
Copy link
Member

bdougie commented Jun 17, 2023

I can't upload an image but the filters on the dashboard does include Python

@bdougie
Copy link
Member Author

bdougie commented Jun 18, 2023

Turns out this is just a problem on mobile. The list is abbreviated.

mobile

image

desktop

Untitled

@OgDev-01
Copy link
Contributor

Hey @bdougie Is the option list on mobile not scrollable?

@bdougie
Copy link
Member Author

bdougie commented Jun 18, 2023

Hey @bdougie Is the option list on mobile not scrollable?

Not on my phone. iPhone 11

@takanome-dev
Copy link
Contributor

Radix ui has a scroll area component that we can use and there is a nice integration with tailwind that we can just take here

@takanome-dev takanome-dev added the 🐛 bug Something isn't working label Jun 19, 2023
@babblebey
Copy link
Contributor

babblebey commented Jun 19, 2023

Hey @takanome-dev, another option we could look is to take advantage of the Scroll Sub-Components on the Radix UI's Select Primitive.

These are:

These components adds scroll buttons on-demand to the top/bottom of the Select.Content component in affordance to show the overflown content.

It also has support for scroll on touch devices, I think it will fit well since the component are already local i.e. sub-component to the @radix-ui/react-select Primitive implemented in our Select component.

What do you think??

@takanome-dev
Copy link
Contributor

Oh great, I think we can use that one. Wanna give it a try?

@babblebey
Copy link
Contributor

Great, I'm happy to .take this 😉

Thank you || Danke || O ṣeun

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.54.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.54.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants