Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Save models to disk progressively instead of once at the end #3

Open
1 task done
mxgrey opened this issue Jun 17, 2024 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Jun 17, 2024

Before proceeding, is there an existing issue or discussion for this?

Description

I haven't looked deeply into the implementation, but based on observed behavior, it seems that models only get saved to disk after all data has been retrieved. This means that if the cache update gets interrupted, no models will be preserved at all. Since the download can take a significant amount of time, this could lead to a lot of wasted effort.

It would be nice if models could get saved to disk as they arrive so even an incomplete cache update has some benefit.

@mxgrey mxgrey added the enhancement New feature or request label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant