Fix broken make generate, which requires CGO
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `make generate` requires CGO support inside the docker image. The golang:1.15-alpine image does not include this support, and this CL adds a RUN command that installs the necessary libraries. Signed-off-by: juliankatz <juliankatz@google.com>
|
We can revert back to non-alpine image if that works better. If so, we should move our builder image to non-alpine too to align |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
make generaterequires CGO support inside the dockerimage. The golang:1.15-alpine image does not include this support, and
this change adds a RUN command that installs the necessary libraries.
Signed-off-by: juliankatz juliankatz@google.com