Fixes crashloop caused by cert gen #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritazh
force-pushed
the
fix-racingcondition
branch
from
cef29f8
to
6d6bf74
Compare
|
Could we add the sleep before the exit so that the Pod isn't blocked on start up? Also, we could block on cert generation with a timeout, that would avoid unnecessary lag in killing the pod. That could be follow-on work b/c fixing the bug takes priority. |
ritazh
force-pushed
the
fix-racingcondition
branch
from
6d6bf74
to
1245fd6
Compare
|
Done |
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
ritazh
force-pushed
the
fix-racingcondition
branch
from
1245fd6
to
01a7f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452
Seems by removing the sleep in main.go in #418 the pod to exit before it has a chance to generate the cert.
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com