Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health and ready checks #396

Merged
merged 4 commits into from
Jan 10, 2020
Merged

Health and ready checks #396

merged 4 commits into from
Jan 10, 2020

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Jan 8, 2020

Fixes #209 and #217

@sozercan
add healthz and readyz check
2a4d99e 
Signed-off-by: Sertaç Özercan <sozercan@users.noreply.github.com>
@sozercan
update yaml
35635ab 
Signed-off-by: Sertaç Özercan <sozercan@users.noreply.github.com>
maxsmythe
maxsmythe approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is this a starting point for also checking for cache warming before readiness returns true?

@sozercan
add containerPort
2d575f7 
Signed-off-by: Sertaç Özercan <sozercan@gmail.com>
@sozercan
Merge branch 'master' into healthz
18f3457 
Signed-off-by: Sertaç Özercan <sozercan@gmail.com>

# Conflicts:
#	main.go
@maxsmythe
Copy link
Contributor

LGTM

@sozercan sozercan merged commit 0f34328 into open-policy-agent:master Jan 10, 2020
@sozercan sozercan deleted the healthz branch January 10, 2020 23:19
@sozercan sozercan mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readiness and Liveness probe missing
2 participants
@sozercan @maxsmythe