Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure scheduler on controller-manager and audit pods #3560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gergelysotidm
Copy link

What this PR does / why we need it:
Enables the configuration of a non-default k8s scheduler on both the audit and controller-manager pods.

Relevant for people who run an alternate scheduler next to the default one. Especially relevant on AWS/EKS, because there the users are not allowed to configure the scheduler.

The default value will use the default k8s scheduler (if you leave the setting out, k8s will assign the pods to the default-scheduler).

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Gergely Soti <gergely.soti@dataminded.be>
@gergelysotidm gergelysotidm requested a review from a team as a code owner September 24, 2024 09:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.14%. Comparing base (3350319) to head (5a375e5).
Report is 150 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (5a375e5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (5a375e5)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3560      +/-   ##
==========================================
- Coverage   54.49%   48.14%   -6.35%     
==========================================
  Files         134      218      +84     
  Lines       12329    15134    +2805     
==========================================
+ Hits         6719     7287     +568     
- Misses       5116     7031    +1915     
- Partials      494      816     +322     
Flag Coverage Δ
unittests 48.14% <ø> (-6.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants