Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to go 1.22 bookworm #3323

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Mar 19, 2024

What this PR does / why we need it:

  • bumps GHA to Go 1.22 and container to 1.22 bookworm
  • bumps controller-gen@v0.14.0 (fixes panic in go 1.22) and conversion-gen@v0.29.3

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Replaces #3263 #3265 #3214

Special notes for your reviewer:

@sozercan sozercan requested a review from a team as a code owner March 19, 2024 21:39
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.76%. Comparing base (3350319) to head (68378ef).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3323      +/-   ##
==========================================
- Coverage   54.49%   46.76%   -7.74%     
==========================================
  Files         134      218      +84     
  Lines       12329    14784    +2455     
==========================================
+ Hits         6719     6913     +194     
- Misses       5116     7070    +1954     
- Partials      494      801     +307     
Flag Coverage Δ
unittests 46.76% <ø> (-7.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozercan sozercan requested a review from ritazh March 27, 2024 20:49
@sozercan sozercan mentioned this pull request Mar 27, 2024
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh
Copy link
Member

ritazh commented Mar 27, 2024

We should update these in framework too to ensure things are in sync.

@sozercan sozercan merged commit 1dca4df into open-policy-agent:master Mar 27, 2024
18 checks passed
@sozercan sozercan deleted the go-122 branch March 28, 2024 02:09
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants