Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutation process to allProcesses list #1516

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

spennymac
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes
Fixes #1515

Special notes for your reviewer:

I opened this up real quick in the event that this was just an oversight from you all and a quick win to close an issue.

Signed-off-by: Spencer McCreary <spencer_mccreary@compulsivesoftware.com>
@spennymac
Copy link
Contributor Author

I signed it

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #1516 (0f18ded) into master (bbdcd7b) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   52.40%   52.77%   +0.37%     
==========================================
  Files          82       82              
  Lines        7431     7431              
==========================================
+ Hits         3894     3922      +28     
+ Misses       3174     3154      -20     
+ Partials      363      355       -8     
Flag Coverage Δ
unittests 52.77% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/config/process/excluder.go 11.76% <ø> (ø)
pkg/readiness/ready_tracker.go 71.10% <0.00%> (+0.61%) ⬆️
pkg/watch/replay.go 81.25% <0.00%> (+2.27%) ⬆️
...onstrainttemplate/constrainttemplate_controller.go 56.93% <0.00%> (+5.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdcd7b...0f18ded. Read the comment docs.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@sozercan sozercan merged commit 0fc227e into open-policy-agent:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mutation process to 'allProcesses' list
4 participants