Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to bats http.send test for idempotence #1473

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

font
Copy link
Contributor

@font font commented Aug 4, 2021

Signed-off-by: Ivan Font ifont@redhat.com

What this PR does / why we need it:
The bats tests rely on common labels to cleanup the test resources such as constrainttemplates that are created throughout the bats tests. This particular CT was missing that common label and as a result was not being deleted at the end. This now adds the label so the bats tests can remain idempotent.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Ref #1119.

Special notes for your reviewer:

Signed-off-by: Ivan Font <ifont@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021

Codecov Report

Merging #1473 (95aa5e0) into master (821db67) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1473      +/-   ##
==========================================
+ Coverage   52.06%   52.07%   +0.01%     
==========================================
  Files          83       83              
  Lines        7593     7593              
==========================================
+ Hits         3953     3954       +1     
+ Misses       3260     3259       -1     
  Partials      380      380              
Flag Coverage Δ
unittests 52.07% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 54.17% <0.00%> (-0.72%) ⬇️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821db67...95aa5e0. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sozercan sozercan merged commit 5975122 into open-policy-agent:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants