[gk-test] Refactor run code into Runner #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbeason
added
the
authorship-tooling
Codecov Report
@@ Coverage Diff @@
## master #1445 +/- ##
==========================================
+ Coverage 50.35% 50.75% +0.40%
==========================================
Files 77 78 +1
Lines 5108 5111 +3
==========================================
+ Hits 2572 2594 +22
+ Misses 2185 2170 -15
+ Partials 351 347 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbeason
force-pushed
the
refactor
branch
2 times, most recently
from
1fcbd99
to
ff33863
Compare
Merged
willbeason
changed the title
Now that much of the test running logic is defined, it is more apparent how to organize it. Code specific to running tests, but which does not change with the nature of the tests being run or how the results are printed, should live in its own place. It may be decorated in the future with objects (like Printers) which are specified by the user. This PR has zero changes to logic - it only moves logic around. Signed-off-by: Will Beason <willbeason@google.com>
julianKatz
pushed a commit
to julianKatz/gatekeeper
that referenced
this pull request
Jul 27, 2021
Now that much of the test running logic is defined, it is more apparent how to organize it. Code specific to running tests, but which does not change with the nature of the tests being run or how the results are printed, should live in its own place. It may be decorated in the future with objects (like Printers) which are specified by the user. This PR has zero changes to logic - it only moves logic around. Signed-off-by: Will Beason <willbeason@google.com> Signed-off-by: juliankatz <juliankatz@google.com>
julianKatz
added a commit
to julianKatz/gatekeeper
that referenced
this pull request
Aug 2, 2021
I recently ran `make vendor` on gatekeeper master and noticed that a number of files from frameworks/constraint were being deleted. Why? It runs out that a recent PR (open-policy-agent#1445) removed a dependency on frameworks/constraint/pkg/apis and `make vendor` was pruning the unused code from the vendor/ directory. As the API types declared in frameworks/constraint are part of the API used in g8r, I thought it appropriate to add them to the scheme. This fixes the problem with make vendor. Signed-off-by: juliankatz <juliankatz@google.com>
julianKatz
added a commit
to julianKatz/gatekeeper
that referenced
this pull request
Aug 2, 2021
I recently ran `make vendor` on gatekeeper master and noticed that a number of files from frameworks/constraint were being deleted. Why? It runs out that a recent PR (open-policy-agent#1445) removed a dependency on frameworks/constraint/pkg/apis and `make vendor` was pruning the unused code from the vendor/ directory. Further, while we might expect the AddToScheme calls to be used when we setup the scheme in main.go, it turns out that we were making essentially duplicate versions of the AddToScheme files in g8r. I've replaced these with a single file that calls all the AddToScheme functions in frameworks/constraint. Signed-off-by: juliankatz <juliankatz@google.com>
maxsmythe
pushed a commit
that referenced
this pull request
Aug 3, 2021
* Add frameworks apis to scheme I recently ran `make vendor` on gatekeeper master and noticed that a number of files from frameworks/constraint were being deleted. Why? It runs out that a recent PR (#1445) removed a dependency on frameworks/constraint/pkg/apis and `make vendor` was pruning the unused code from the vendor/ directory. As the API types declared in frameworks/constraint are part of the API used in g8r, I thought it appropriate to add them to the scheme. This fixes the problem with make vendor. Signed-off-by: juliankatz <juliankatz@google.com> * Add frameworks apis to scheme I recently ran `make vendor` on gatekeeper master and noticed that a number of files from frameworks/constraint were being deleted. Why? It runs out that a recent PR (#1445) removed a dependency on frameworks/constraint/pkg/apis and `make vendor` was pruning the unused code from the vendor/ directory. Further, while we might expect the AddToScheme calls to be used when we setup the scheme in main.go, it turns out that we were making essentially duplicate versions of the AddToScheme files in g8r. I've replaced these with a single file that calls all the AddToScheme functions in frameworks/constraint. Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that much of the test running logic is defined, it is more apparent
how to organize it.
Code specific to running tests, but which does not change with the
nature of the tests being run or how the results are printed, should
live in its own place. It may be decorated in the future with objects
(like Printers) which are specified by the user.
This PR has zero changes to logic - it only moves logic around.
Signed-off-by: Will Beason willbeason@google.com