Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick of #1240: Do not allow status objects from other pods to trigger constraint reconciles #1371

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Jun 17, 2021

What this PR does / why we need it:

Cherry pick of #1240 for v3.4.1

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

…onciles

Signed-off-by: Max Smythe <smythe@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1371 (45e13e2) into release-3.4 (96e8f1f) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.4    #1371      +/-   ##
===============================================
+ Coverage        49.96%   49.98%   +0.02%     
===============================================
  Files               64       64              
  Lines             4517     4523       +6     
===============================================
+ Hits              2257     2261       +4     
- Misses            1950     1951       +1     
- Partials           310      311       +1     
Flag Coverage Δ
unittests 49.98% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/constraint/constraint_controller.go 4.22% <0.00%> (ø)
...platestatus/constrainttemplatestatus_controller.go 69.62% <71.42%> (-0.25%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 56.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e8f1f...45e13e2. Read the comment docs.

@sozercan sozercan merged commit 7a50c3b into open-policy-agent:release-3.4 Jun 17, 2021
@sozercan sozercan deleted the automated-cherry-pick-of-#1240-upstream-release-3.4 branch June 17, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants