Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define gatekeeper-test CLI, import cobra #1370

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

willbeason
Copy link
Member

Keeping this PR small so that in future PRs reviewers can focus on the
code changes and modifications to vendor/ won't be as noisy.

Note that per the design discussion meeting, the name for the CLI will
initially be "gatekeeper-test-alpha" to communicate to users that it is
not stable.

Signed-off-by: Will Beason willbeason@google.com

Keeping this PR small so that in future PRs reviewers can focus on the
code changes and modifications to vendor/ won't be as noisy.

Note that per the design discussion meeting, the name for the CLI will
initially be "gatekeeper-test-alpha" to communicate to users that it is
not stable.

Signed-off-by: Will Beason <willbeason@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1370 (0e36f48) into master (b3c706a) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
+ Coverage   49.33%   49.53%   +0.20%     
==========================================
  Files          68       68              
  Lines        4926     4926              
==========================================
+ Hits         2430     2440      +10     
+ Misses       2146     2140       -6     
+ Partials      350      346       -4     
Flag Coverage Δ
unittests 49.53% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 56.31% <0.00%> (+3.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c706a...0e36f48. Read the comment docs.

@willbeason
Copy link
Member Author

Part of #1369

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason willbeason added the authorship-tooling Tools for authors of Gatekeeper Constraints, Templates, Mutators label Jun 17, 2021
@willbeason willbeason added this to the gk-test cli alpha milestone Jun 17, 2021
@willbeason willbeason self-assigned this Jun 17, 2021
@willbeason willbeason merged commit e4e7cec into open-policy-agent:master Jun 17, 2021
@willbeason willbeason deleted the gatekeeper-test branch June 17, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authorship-tooling Tools for authors of Gatekeeper Constraints, Templates, Mutators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants