Add unit tests for pkg/util #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several logic paths weren't tested, so this commit adds tests for those paths. Also use new go1.13 error checking for these tests. Signed-off-by: Will Beason <willbeason@google.com>
ritazh
approved these changes
Jun 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
+ Coverage 48.42% 48.86% +0.43%
==========================================
Files 68 68
Lines 4913 4916 +3
==========================================
+ Hits 2379 2402 +23
+ Misses 2181 2157 -24
- Partials 353 357 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several logic paths weren't tested, so this commit adds tests for those
paths. This gets test coverage for the package from ~82% to ~94%.
Also use new go 1.13 error checking for these tests.