Use "revive" instead of "golint" linter #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
+ Coverage 48.52% 48.67% +0.14%
==========================================
Files 68 68
Lines 4894 4890 -4
==========================================
+ Hits 2375 2380 +5
+ Misses 2166 2160 -6
+ Partials 353 350 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbeason
force-pushed
the
revive
branch
2 times, most recently
from
3e75a12
to
fee30b8
Compare
sozercan
reviewed
May 20, 2021
| @@ -1,17 +1,23 @@ | |||
| linter-settings: | |||
| linters-settings: | |||
|
Looks like git diff fails. Can you run |
Ahh, that's it. Done! |
Per the golint repository, the golint linter is no longer maintained. The recommended golangci-lint replacement is revive, so this PR switches us to use the new linter. This commit also includes all necessary changes to make the new linter pass. In configuring this I noticed the that our .golangci.yaml had a typo which caused our misspell and lll configurations to be silently discarded - I've corrected "linter" to "linters" and resolved the spelling mistakes it found. Also upgrade golangci-lint from 1.37.1 to 1.40.1 as previous versions did not configure gosec properly. Signed-off-by: Will Beason <willbeason@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Per the golint repository, the golint linter is no longer maintained.
The recommended golangci-lint replacement is revive, so this PR switches
us to use the new linter. This commit also includes all necessary
changes to make the new linter pass.
In configuring this I noticed the that our .golangci.yaml had a typo
which caused our
misspellandlllconfigurations to be silentlydiscarded - I've corrected "linter" to "linters" and resolved the
spelling mistakes it found.
Note: when running locally, you may need to upgrade to golangci-lint
1.40.1 as some previous versions did not properly configure gosec.
Signed-off-by: Will Beason willbeason@google.com