Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1203 - log ucloop.uc in audit #1210

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Mar 31, 2021

Signed-off-by: Rita Zhang rita.z.zhang@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1203

Special notes for your reviewer:

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #1210 (d9bf4df) into master (cd9de86) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   49.96%   49.90%   -0.07%     
==========================================
  Files          64       64              
  Lines        4517     4517              
==========================================
- Hits         2257     2254       -3     
- Misses       1950     1953       +3     
  Partials      310      310              
Flag Coverage Δ
unittests 49.90% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/audit/manager.go 0.00% <0.00%> (ø)
pkg/readiness/object_tracker.go 80.97% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9de86...d9bf4df. Read the comment docs.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit cca802c into open-policy-agent:master Apr 1, 2021
@ritazh ritazh deleted the fix-1203 branch April 1, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

constraintsError": "json: unsupported type: map[util.KindVersionResource]unstructured.Unstructured"
4 participants