Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness retries support for Constraint Templates #1160

Conversation

julianKatz
Copy link
Contributor

Signed-off-by: juliankatz juliankatz@google.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@julianKatz julianKatz force-pushed the 177367246-1063-need-readiness-tracker-retries-for-canceltemplate-as-well branch from 0212aa4 to a5c0bb3 Compare March 3, 2021 02:42
Copy link
Contributor

@shomron shomron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@julianKatz julianKatz force-pushed the 177367246-1063-need-readiness-tracker-retries-for-canceltemplate-as-well branch 5 times, most recently from efa1a74 to ac15bd1 Compare March 24, 2021 01:48
@julianKatz
Copy link
Contributor Author

@ritazh @shomron

I've updated this PR to include unit tests for TryCancelTemplate. PTAL

Signed-off-by: juliankatz <juliankatz@google.com>
@julianKatz julianKatz force-pushed the 177367246-1063-need-readiness-tracker-retries-for-canceltemplate-as-well branch from ac15bd1 to d9b8b97 Compare March 24, 2021 21:20
Copy link
Contributor

@shomron shomron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks for adding the tests!

@maxsmythe maxsmythe merged commit 86ea57f into open-policy-agent:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants