Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to mutation related errors #1142

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

mmirecki
Copy link
Contributor

The mutations error messages are sometimes missing information about the mutation for which a failure occurred.
This patch add some more info to some of the error messages.

@codecov-io
Copy link

Codecov Report

Merging #1142 (0dfd241) into master (705a40c) will increase coverage by 0.13%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
+ Coverage   48.47%   48.61%   +0.13%     
==========================================
  Files          63       63              
  Lines        4363     4363              
==========================================
+ Hits         2115     2121       +6     
+ Misses       1986     1983       -3     
+ Partials      262      259       -3     
Flag Coverage Δ
unittests 48.61% <7.69%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mutation/assignmeta_mutator.go 47.94% <0.00%> (ø)
pkg/mutation/types/mutator.go 50.00% <0.00%> (ø)
pkg/mutation/assign_mutator.go 37.25% <5.88%> (ø)
pkg/mutation/system.go 81.39% <25.00%> (ø)
pkg/readiness/objset.go 75.00% <0.00%> (-12.50%) ⬇️
pkg/readiness/object_tracker.go 78.68% <0.00%> (-1.10%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 55.66% <0.00%> (+2.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705a40c...0dfd241. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

LGTM

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

looks like DCO needs to be signed

Signed-off-by: mmirecki <mmirecki@redhat.com>
@mmirecki
Copy link
Contributor Author

LGTM

looks like DCO needs to be signed

fixed

@sozercan sozercan merged commit 95ec2f0 into open-policy-agent:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants