Use ID only for cache deletion. #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we reconcile deletions, we don't have the full object. This is causing a panic in parsing. Here we change the Remove method to take the ID of the object instead of the object itself. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Merged
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
+ Coverage 46.59% 46.86% +0.27%
==========================================
Files 62 62
Lines 4024 4024
==========================================
+ Hits 1875 1886 +11
+ Misses 1901 1895 -6
+ Partials 248 243 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@ritazh LGTY? I think this helps your outstanding PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When we reconcile deletions, we don't have the full object.
This is causing a panic in parsing. Here we change the Remove method to take the ID of the object instead of the object itself.