Adding modifiable priority class to controller-manager and audit deployment #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 46.70% 47.05% +0.35%
==========================================
Files 62 62
Lines 3987 3987
==========================================
+ Hits 1862 1876 +14
+ Misses 1879 1871 -8
+ Partials 246 240 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BBzzz
force-pushed
the
add_prio_class
branch
2 times, most recently
from
df1f593
to
231b61c
Compare
sozercan
reviewed
Dec 7, 2020
sozercan
reviewed
Dec 7, 2020
sozercan
reviewed
Dec 7, 2020
|
@BBzzz can you run |
|
Hi @sozercan! |
BBzzz
force-pushed
the
add_prio_class
branch
2 times, most recently
from
f0c479d
to
7236c6b
Compare
BBzzz
force-pushed
the
add_prio_class
branch
from
7236c6b
to
4fbb611
Compare
|
Sorry for the delay! It looks like I don't have permission to rebase this PR off of current master. Any chance you can do so, @BBzzz, to unblock merging? |
…oyment Signed-off-by: Botond Borbely <botond.borbely@nokia.com>
BBzzz
force-pushed
the
add_prio_class
branch
from
4fbb611
to
2459a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introducing the priority class to this deployment.
This value can be set from outside (e.g. when installing this helm chart)