Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor duplicate code: assign_controller.go and assignmetadata_controller.go #1449

Closed
julianKatz opened this issue Jul 19, 2021 · 1 comment · Fixed by #1474
Closed

Refactor duplicate code: assign_controller.go and assignmetadata_controller.go #1449

julianKatz opened this issue Jul 19, 2021 · 1 comment · Fixed by #1474
Assignees
@maxsmythe
Labels
bug Something isn't working

Comments

@julianKatz
Copy link
Contributor

These two files are almost exactly the same, and could be DRYed significantly:
@julianKatz julianKatz added the bug Something isn't working label Jul 19, 2021
@julianKatz julianKatz self-assigned this Jul 21, 2021
@willbeason willbeason self-assigned this Jul 26, 2021
@willbeason
Copy link
Member

I'll be touching some of this for working on conflicting mutations.

@maxsmythe maxsmythe self-assigned this Aug 4, 2021
maxsmythe added a commit to maxsmythe/gatekeeper that referenced this issue Aug 4, 2021
@maxsmythe
Deduplicate mutator controller logic.
1ed70fd 
Fixes open-policy-agent#1449

Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe mentioned this issue Aug 4, 2021
Merged
maxsmythe added a commit to maxsmythe/gatekeeper that referenced this issue Aug 4, 2021
@maxsmythe
Deduplicate mutator controller logic
7a22df5 
Fixes open-policy-agent#1449

Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe added a commit to maxsmythe/gatekeeper that referenced this issue Aug 4, 2021
@maxsmythe
Deduplicate mutator controller logic
b028142 
Fixes open-policy-agent#1449

Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe added a commit to maxsmythe/gatekeeper that referenced this issue Aug 4, 2021
@maxsmythe
Deduplicate mutator controller logic
f18e7af 
Fixes open-policy-agent#1449

Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe added a commit to maxsmythe/gatekeeper that referenced this issue Aug 4, 2021
@maxsmythe
Deduplicate mutator controller logic
1f9f71b 
Fixes open-policy-agent#1449

Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe added a commit to maxsmythe/gatekeeper that referenced this issue Aug 7, 2021
@maxsmythe
Deduplicate mutator controller logic
8aa72b3 
Fixes open-policy-agent#1449

Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe added a commit that referenced this issue Aug 9, 2021
@maxsmythe
Deduplicate mutator controller logic (#1474)
407611a 
Fixes #1449

Signed-off-by: Max Smythe <smythe@google.com>
@willbeason willbeason mentioned this issue Aug 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxsmythe maxsmythe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate mutator controller logic maxsmythe/gatekeeper
3 participants
@julianKatz @willbeason @maxsmythe