-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Trailing Whitespace #10398
Remove Trailing Whitespace #10398
Conversation
Removes trailing whitespace in one spot to allow IDE's to enable the auto-remove trailing whitespace setting without adding a lot of extra diffs to commits. When you make a 1 line change in a file and have 100 lines of trailing whitespace changes in the diff, it is time consuming to review. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
8b42e55
to
8d62b8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the changes, but I'm not sure if the trailing whitespace in the RST files has any special meaning. @jsquyres should chime in on those changes before this gets committed.
This is the same as the infamous clang-format patch: it pollutes the git history and makes git blame virtually useless. The actual benefit of whitespace-only changes for the community is asymptotically approaching zero. IMHO, you should fix your editor to remove whitespaces only on lines or files you edited or at least provide a substantive change that justifies changing the files. |
The trim trailing whitespace on only lines edited is a good idea, but it is still a feature idea with VSCode: microsoft/vscode#1315 (for 5 years now). To fix git blame, you can do: |
@a-szegel I realize that the concept of a whitespace-fixing-only set of commits is a bit controversial, but would it be possible to separate out the whitespace fixes to files that end in |
Since this PR became controversial, I extracted the part of this commit that fixes the whitespace in the RST man pages and put that in #10652. |
Since it looks like we're not moving forward with this change, I'm closing this PR. Please re-open if necessary. |
Removes trailing whitespace in one spot to allow IDE's to enable the auto-remove
trailing whitespace setting without adding a lot of extra diffs to
commits. When you make a 1 line change in a file and have 100 lines of
trailing whitespace changes in the diff, it is time consuming to review.
Signed-off-by: Seth Zegelstein szegel@amazon.com